extract repl to be its own artifact #24243
Conversation
project/Build.scala
Outdated
| .settings(publishSettings) | ||
| .settings( | ||
| name := "scala3-repl", | ||
| moduleName := "scala3-repl", |
There was a problem hiding this comment.
will sbt console still work after moving the repl into a spearate artifact?
There was a problem hiding this comment.
There was a problem hiding this comment.
So to make it explicit, sbt console on a Scala 3.8 project will only work with future sbt releases.
There was a problem hiding this comment.
Yes, sbt 1.12.0-M1 is already released with the fix. Anyways, with the stdlib changes, sbt wasn't working for some of the projects. That's why we decided to include this change in 3.8.0 so that we will break tooling just once.
With everything that is happening for `3.8.0`, I believe it is now time to remove the old runner infrastructure and the `scala_legacy` script too. `scala-cli` has been shipped with every release of Scala since `3.5.0`. In preparation for #24243
hamzaremmal
force-pushed
the
repl-artifact
branch
from
cb4e953 to
c05242b
Compare
First step towards extracting the `repl` to be its own artifact. We need to remove that because the repl will have a dependency on the compiler and we cannot have the compiler depend on the repl too (cyclic dependency) Related to #24243
hamzaremmal
force-pushed
the
repl-artifact
branch
from
9a67e1e to
cc61ffa
Compare
hamzaremmal
force-pushed
the
repl-artifact
branch
3 times, most recently
from
4c768c9 to
d8b4c50
Compare
hamzaremmal
force-pushed
the
repl-artifact
branch
from
3e6b35d to
ff05ec8
Compare
| ./bin/scalac -d "$OUT/out.jar" tests/pos/i12973.scala | ||
| echo "Bug12973().check" | TERM=dumb ./bin/scala -cp "$OUT/out.jar" > "$tmp" 2>&1 | ||
| grep -qe "Bug12973 is fixed" "$tmp" | ||
| #echo "testing i12973" |
There was a problem hiding this comment.
Was this going to be commented out before merge? If there's a bug/regression let's create an issue an add comment here
There was a problem hiding this comment.
It needs scala-cli to migrate to use this artifact for this test to be enabled. I don't want to waste CI time with the comment. We will remember. If you want to open an issue, you can do it.
cc @Gedochao
hamzaremmal
added
the
backport:nominated
See #24243 Also removes the duplicated manifest file
5 participants
No description provided.